ktmud commented on PR #18778: URL: https://github.com/apache/superset/pull/18778#issuecomment-1106806012
The new geo data source is a very nice addition. @Yann-J can you also add a screenshot of how the attribution looks like in a dashboard when the chart is small? Looking at the size of the new files, I'm wondering whether it is now time to think about a long-term maintenance mode for geo-boundaries in Superset. While these new maps are relevant to your organization, it may never be used by 90% of other Superset users. We had a section in [Superset docs](https://superset.apache.org/docs/miscellaneous/country-map-tools/) specifically for users who want to add their own maps so that the size of Superset pip package does not bloat up. A potential solution is to publish these maps in a separate GitHub repo and add a superset command to download them to `./superset/static/assets/geoboundaries` on demand. The list of available countries can be configured in `config.py`, with the default being the list of all available files in the `geoboundaries` directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
