eschutho commented on code in PR #19855: URL: https://github.com/apache/superset/pull/19855#discussion_r861046636
########## superset-frontend/packages/superset-ui-chart-controls/src/types.ts: ########## @@ -65,6 +65,11 @@ export interface DatasourceMeta { granularity_sqla?: string; datasource_name: string | null; description: string | null; + sl_dataset?: { + sl_table?: any; Review Comment: I think we should make different interfaces for the different datasource types and then create a type that is a union of all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org