jinghua-qa commented on PR #19821:
URL: https://github.com/apache/superset/pull/19821#issuecomment-1112386048
> @jinghua-qa I executed the tests locally and it's really slow. The main
reason is that we are recreating the dashboard and waiting for all charts to be
loaded for each test as you can see in the `beforeEach` below:
>
> ```
> beforeEach(() => {
> cy.login();
> cleanUp();
> copyTestDashboard("World Bank's Data");
> WORLD_HEALTH_CHARTS.forEach(waitForChartLoad);
> closeDashboardToastMessage();
> });
> ```
>
> The majority of tests don't need a fresh initial state to execute. We can
start the initial state with an existing filter and handle these types of tests
without recreating the whole dashboard:
>
> * 'User can expand / retract native filter sidebar on a dashboard
> * Verify setting options and tooltips for value filter
> * User can check 'Filter has default value
> ...
>
> For tests like:
>
> * User can create a time range filter
> * User can create a time grain filter
> * User can create a time column filter
> ...
>
> We can just add new filters to execute the tests.
>
> Only a few tests will required a complete fresh initial state. Making
these suggested changes will greatly improve execution time.
Separated the tests into 2 different setup suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
