rusackas commented on code in PR #19881:
URL: https://github.com/apache/superset/pull/19881#discussion_r861367868
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts:
##########
@@ -106,7 +107,25 @@ const config: ControlPanelConfig = {
},
],
['color_picker'],
+ [
+ {
+ name: 'color_by',
+ config: {
+ type: 'RadioButtonControl',
+ label: t('Color by'),
+ default: ColorBy.metric,
+ options: [
+ [ColorBy.metric, t('metric')],
+ [ColorBy.country, t('country')],
Review Comment:
```suggestion
[ColorBy.metric, t('Metric')],
[ColorBy.country, t('Country')],
```
Nitpicking. This really doesn't matter since the CSS capitalizes it. But if
we ever move away from all-caps in the design, then this will be nicely
capitalized that day ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
