diegomedina248 opened a new pull request, #19898: URL: https://github.com/apache/superset/pull/19898
### SUMMARY This PR adjusts the metrics popover in Explore to: * When editing the title, hitting enter should save the title as well * Adjust the size of the view & edit modes so that they take the same height and prevent the popover from changing positions Additionally, took the opportunity to: * Refactor the file involved to use typescript * Refactor the tests to use react testing library instead, and added more tests scenarios ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not a visual change to see, so no before/after: https://user-images.githubusercontent.com/17252075/165967447-5d9d76c5-b3bc-4d93-ba33-eee8b5cb80a6.mov ### TESTING INSTRUCTIONS Explore a chart, try to edit a metric and ensure the title gets saved on enter. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
