diegomedina248 opened a new pull request, #19902: URL: https://github.com/apache/superset/pull/19902
### SUMMARY This PR enables the popovers in the explore to be closed when hitting the escape key. Also, improves the locking of the explore scroll, so that the popovers are pinned to the triggering div until they're closed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No way to visually show the difference, so this is the actual result: https://user-images.githubusercontent.com/17252075/166059870-309451f9-3eeb-4db5-bb15-f593a2011819.mov ### TESTING INSTRUCTIONS In the explore: * Try to edit the Data, be it metrics, columns, dimensions, filters, etc, and ensure it continues to work as before * Hit the escape key while a popover is open and ensure it closes * Ensure you can still interact with the popver (type, click, etc). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
