rusackas commented on PR #19918: URL: https://github.com/apache/superset/pull/19918#issuecomment-1116769707
I think there are two little problems that need to be addressed in this PR. The small nitpicky one: I think having a whole _section_ for Bar orientation is a bit much... it leads to having "Chart orientation" and "Bar orientation" right next to each other, which is redundant. I'm wondering if it makes more sense to move the "Bar orientation" control into the "Chart options" section, rather than creating a new section. And the trickier one: When you transpose the chart between row and column orientation, the other controls may now confuse people. We refer to some of the controls as "x axis" and "y axis" which is no longer the case. I think we need one of two possible solutions here: • Update the terminology, like "Metric axis" and "Dimension axis" to be more specific • Updating the labeling of the controls so that the X and Y labels update on the fly depending on chart orientation, and the controls remain "truthful" Thoughts @stephenLYZ or @villebro ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
