[GitHub] [superset] john-bodley opened a new pull request, #19941: fix(reports): Clear last value when state is WORKING

[GitBox]

john-bodley opened a new pull request, #19941:
URL: https://github.com/apache/superset/pull/19941

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   
   This PR fixes an issue with the alert feature, specifically the execution 
log reports different alert values for different states within the same 
execution run. Per 
[this](https://apache-superset.slack.com/archives/G013HAE6Y0K/p1651543102805559)
 Slack thread the underlying issue is the report schedule synopsis—from which 
the execution log is created, i.e., a point-in-time snapshot—is when the state 
is `WORKING` the `last_value` and `last_value_row_json` need to be cleared 
otherwise they incorrectly reflect the values of the previous execution run.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before Migration
   
   <img width="1335" alt="Screen Shot 2022-05-03 at 8 06 09 PM" 
src="https://user-images.githubusercontent.com/4567245/166618425-b871ea01-6897-4d23-986b-7c2fd9fcfec1.png";>
   
   #### After Migration
   
   <img width="1348" alt="Screen Shot 2022-05-03 at 8 06 37 PM" 
src="https://user-images.githubusercontent.com/4567245/166618440-76d38a6d-abc3-43bb-896a-f31f34f26f27.png";>
   
   ### TESTING INSTRUCTIONS
   
   Added unit tests and migration. The migration successfully ran in under a 
minute on a replica of Airbnb's production database with ~ 50,000 execution 
logs.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [x] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [x] Migration is atomic, supports rollback & is backwards-compatible
     - [x] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org