ktmud commented on code in PR #19954:
URL: https://github.com/apache/superset/pull/19954#discussion_r866031300


##########
superset-frontend/src/dashboard/components/gridComponents/Header.jsx:
##########
@@ -176,11 +176,7 @@ class Header extends React.PureComponent {
                   showTooltip={false}
                 />
                 {!editMode && (
-                  <AnchorLink
-                    anchorLinkId={component.id}
-                    filters={filters}
-                    showShortLinkButton
-                  />
+                  <AnchorLink id={component.id} dashboardId={dashboardId} />

Review Comment:
   Adding `dashboardId` fixes the bug where the copy button doesn't copy the 
right URL for section headers in dashboards.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to