villebro opened a new pull request, #19972: URL: https://github.com/apache/superset/pull/19972
### SUMMARY `d3-svg-legend` version 2 is incompatible with `d3` version 3 (see: https://github.com/susielu/d3-legend/issues/58). I contemplated the option of bumping `d3` to version 4, but decided against it due to the following reasons: - The API has been totally overhauled in `d3` version 4 and would have required fairly big changes - `d3` is now on version 7 - `d3-svg-legend` has been stale for 4 years Instead I think we should just migrate this plugin to `d3` version 7 or the equivalent ECharts version (https://echarts.apache.org/examples/en/editor.html?c=heatmap-cartesian) while migrating this plugin to the v1 chart data endpoint. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
