diegomedina248 opened a new pull request, #20004:
URL: https://github.com/apache/superset/pull/20004

   ### SUMMARY
   The connect a database modal, when in the SQL Lab, is not displaying the 
information in the URI form.
   
   The reason is that the SQL Lab uses and customizes the antd Tabs component, 
and by changing the design it also affects this modal.
   
   This PR sets the proper styles for the modal, to set and prevent this issue
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://user-images.githubusercontent.com/17252075/167487441-ada4571e-24ba-4b3d-aead-104aec340ca2.mov
   
   After:
   
   
https://user-images.githubusercontent.com/17252075/167487491-abdcc684-e889-491a-b7e4-3d6019ced02c.mov
   
   ### TESTING INSTRUCTIONS
   * Go to sql lab
   * Select the + menu
   * Select the data menu
   * Connect a new database
   * Select a database
   * Switch to the URI form
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to