ktmud commented on code in PR #19966:
URL: https://github.com/apache/superset/pull/19966#discussion_r868868632
##########
superset/examples/misc_dashboard.py:
##########
@@ -211,11 +210,7 @@ def load_misc_dashboard() -> None:
"""
)
pos = json.loads(js)
- slices = (
-
db.session.query(Slice).filter(Slice.slice_name.in_(misc_dash_slices)).all()
- )
- slices = sorted(slices, key=lambda x: x.id)
- update_slice_ids(pos, slices)
+ pos, slices = update_slice_ids(pos)
Review Comment:
Ah, right! I'm surprised test cases didn't catch this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
