eschutho commented on code in PR #20014:
URL: https://github.com/apache/superset/pull/20014#discussion_r869501226
##########
superset/explore/form_data/commands/create.py:
##########
@@ -39,20 +39,23 @@ def __init__(self, cmd_params: CommandParameters):
def run(self) -> str:
self.validate()
try:
- dataset_id = self._cmd_params.dataset_id
+ datasource_id = self._cmd_params.datasource_id
+ datasource_type = self._cmd_params.datasource_type
chart_id = self._cmd_params.chart_id
tab_id = self._cmd_params.tab_id
actor = self._cmd_params.actor
form_data = self._cmd_params.form_data
- check_access(dataset_id, chart_id, actor)
- contextual_key = cache_key(session.get("_id"), tab_id, dataset_id,
chart_id)
+ check_access(datasource_id, chart_id, actor, datasource_type)
+ contextual_key = cache_key(
+ session.get("_id"), tab_id, datasource_id, chart_id
Review Comment:
missing datasource_type here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
