kgopal492 opened a new pull request, #20018: URL: https://github.com/apache/superset/pull/20018
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> * Rationale: Saving a resource is not always instantaneous. In the `AddDatasetModal`, while a dataset is being saved, the primary "Add" button is not disabled - allowing user to click on the "Add" button multiple times while the resource is being saved. This allows the user to add duplicate datasets * This PR adds a `primaryButtonLoading` prop to the `Modal` component * The `AddDatasetModal` passes a loading prop to the `Modal` component while the resource creation is loading ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> https://user-images.githubusercontent.com/23270317/167711073-cefa43b5-0eb1-4dc0-9bba-566e74dd3091.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> * Add delay to `superset.datasets.api.py` in the POST function on the `\` path (dataset creation path) * Add a new dataset and verify that the button is disabled & loading while the dataset is being created ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
