villebro commented on code in PR #19999:
URL: https://github.com/apache/superset/pull/19999#discussion_r870195974
##########
superset/connectors/sqla/models.py:
##########
@@ -1120,7 +1120,9 @@ def is_alias_used_in_orderby(col: ColumnElement) -> bool:
col.name = f"{col.name}__"
def get_sqla_row_level_filters(
- self, template_processor: BaseTemplateProcessor
+ self,
+ template_processor: BaseTemplateProcessor,
+ username: Optional[str] = None,
Review Comment:
nit: `username` is missing in the docstring here and in
`security_manager.get_rls_filters`. The main description says it retrieves rls
filters for "the current user" - we should perhaps remove that text from both
docstrings and state that if `username` is missing, it will fall back to the
current user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
