betodealmeida commented on code in PR #20030: URL: https://github.com/apache/superset/pull/20030#discussion_r870826245
########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session Review Comment: Small nit, but it's nice to standardize: in your other methods the `session` is the first argument, in this one it's the last. I'd move it to first argument here, for consistency. ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session + ) -> Datasource: + if datasource_type not in cls.sources: + raise DatasetNotFoundError() + + datasource = ( + session.query(cls.sources[datasource_type]) + .filter_by(id=datasource_id) + .one_or_none() + ) + + if not datasource: + raise DatasetNotFoundError() + + return datasource + + @classmethod + def get_all_datasources(cls, session: Session) -> List[Datasource]: + datasources: List[Datasource] = [] + for source_class in DatasourceDAO.sources.values(): + qry = session.query(source_class) + if isinstance(source_class, SqlaTable): + qry = source_class.default_query(qry) + datasources.extend(qry.all()) + return datasources + + @classmethod + def get_datasource_by_name( # pylint: disable=too-many-arguments + cls, + session: Session, + datasource_type: DatasourceType, + datasource_name: str, + schema: str, + database_name: str, Review Comment: A similar small nit here: in general `schema` comes after `database` in our functions/methods (since they are hierarchical), I would swap the order for consistency. ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] Review Comment: ```suggestion Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery] ``` We don't want `Datasource` to be of type `Any` — on the contrary, it's really nice that the type clearly defines what constitutes a datasource. ########## tests/unit_tests/dao/datasource_test.py: ########## @@ -0,0 +1,181 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import pytest +from sqlalchemy.orm.session import Session + +from superset.utils.core import DatasourceType + + +def create_test_data(session: Session) -> None: Review Comment: You can also rewrite this as a fixture: ```python @pytest.fixture def session_with_data(session: Session) -> Iterator[Session]: ... # code of `create_test_data` here yield session ``` And then in your tests: ```python def test_get_datasource_sqlatable(app_context: None, session_with_data: Session) -> None: ... ``` But there's no need, a function like this also works fine. ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session + ) -> Datasource: + if datasource_type not in cls.sources: + raise DatasetNotFoundError() Review Comment: We should create a custom exception here (`DatasourceTypeNotSupportedError`, for example). ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session + ) -> Datasource: + if datasource_type not in cls.sources: + raise DatasetNotFoundError() + + datasource = ( + session.query(cls.sources[datasource_type]) + .filter_by(id=datasource_id) + .one_or_none() + ) + + if not datasource: + raise DatasetNotFoundError() + + return datasource + + @classmethod + def get_all_datasources(cls, session: Session) -> List[Datasource]: + datasources: List[Datasource] = [] + for source_class in DatasourceDAO.sources.values(): + qry = session.query(source_class) + if isinstance(source_class, SqlaTable): + qry = source_class.default_query(qry) + datasources.extend(qry.all()) + return datasources + + @classmethod + def get_datasource_by_name( # pylint: disable=too-many-arguments + cls, + session: Session, + datasource_type: DatasourceType, + datasource_name: str, + schema: str, + database_name: str, + ) -> Optional[Datasource]: + datasource_class = DatasourceDAO.sources[datasource_type] + if isinstance(datasource_class, SqlaTable): + return datasource_class.get_datasource_by_name( + session, datasource_name, schema, database_name + ) + return None + + @classmethod + def query_datasources_by_permissions( # pylint: disable=invalid-name + cls, + session: Session, + database: Database, + permissions: Set[str], + schema_perms: Set[str], + ) -> List[Datasource]: + # TODO(bogdan): add unit test + datasource_class = DatasourceDAO.sources[DatasourceType[database.type]] + if isinstance(datasource_class, SqlaTable): + return ( + session.query(datasource_class) + .filter_by(database_id=database.id) + .filter( + or_( + datasource_class.perm.in_(permissions), + datasource_class.schema_perm.in_(schema_perms), + ) + ) + .all() + ) + return [] + + @classmethod + def get_eager_datasource( + cls, session: Session, datasource_type: str, datasource_id: int + ) -> Optional[Datasource]: + """Returns datasource with columns and metrics.""" + datasource_class = DatasourceDAO.sources[DatasourceType[datasource_type]] + if isinstance(datasource_class, SqlaTable): + return ( + session.query(datasource_class) + .options( + subqueryload(datasource_class.columns), + subqueryload(datasource_class.metrics), + ) + .filter_by(id=datasource_id) + .one() + ) + return None + + @classmethod + def query_datasources_by_name( + cls, + session: Session, + database: Database, + datasource_name: str, + schema: Optional[str] = None, + ) -> List[Datasource]: + datasource_class = DatasourceDAO.sources[DatasourceType[database.type]] + if isinstance(datasource_class, SqlaTable): Review Comment: Ditto here. ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session + ) -> Datasource: + if datasource_type not in cls.sources: + raise DatasetNotFoundError() + + datasource = ( + session.query(cls.sources[datasource_type]) + .filter_by(id=datasource_id) + .one_or_none() + ) + + if not datasource: + raise DatasetNotFoundError() + + return datasource + + @classmethod + def get_all_datasources(cls, session: Session) -> List[Datasource]: + datasources: List[Datasource] = [] + for source_class in DatasourceDAO.sources.values(): + qry = session.query(source_class) + if isinstance(source_class, SqlaTable): + qry = source_class.default_query(qry) + datasources.extend(qry.all()) + return datasources + + @classmethod + def get_datasource_by_name( # pylint: disable=too-many-arguments + cls, + session: Session, + datasource_type: DatasourceType, + datasource_name: str, + schema: str, + database_name: str, + ) -> Optional[Datasource]: + datasource_class = DatasourceDAO.sources[datasource_type] + if isinstance(datasource_class, SqlaTable): + return datasource_class.get_datasource_by_name( + session, datasource_name, schema, database_name + ) + return None + + @classmethod + def query_datasources_by_permissions( # pylint: disable=invalid-name + cls, + session: Session, + database: Database, + permissions: Set[str], + schema_perms: Set[str], + ) -> List[Datasource]: + # TODO(bogdan): add unit test + datasource_class = DatasourceDAO.sources[DatasourceType[database.type]] + if isinstance(datasource_class, SqlaTable): Review Comment: Nit, if you invert the if you can remove an indentation level: ```python if not isinstance(datasource_class, SqlaTable): return [] return ( session.query(...) ... ) ``` ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session + ) -> Datasource: + if datasource_type not in cls.sources: + raise DatasetNotFoundError() + + datasource = ( + session.query(cls.sources[datasource_type]) + .filter_by(id=datasource_id) + .one_or_none() + ) + + if not datasource: + raise DatasetNotFoundError() + + return datasource + + @classmethod + def get_all_datasources(cls, session: Session) -> List[Datasource]: + datasources: List[Datasource] = [] + for source_class in DatasourceDAO.sources.values(): + qry = session.query(source_class) + if isinstance(source_class, SqlaTable): + qry = source_class.default_query(qry) + datasources.extend(qry.all()) + return datasources + + @classmethod + def get_datasource_by_name( # pylint: disable=too-many-arguments + cls, + session: Session, + datasource_type: DatasourceType, + datasource_name: str, + schema: str, + database_name: str, + ) -> Optional[Datasource]: + datasource_class = DatasourceDAO.sources[datasource_type] + if isinstance(datasource_class, SqlaTable): + return datasource_class.get_datasource_by_name( + session, datasource_name, schema, database_name + ) + return None + + @classmethod + def query_datasources_by_permissions( # pylint: disable=invalid-name + cls, + session: Session, + database: Database, + permissions: Set[str], + schema_perms: Set[str], + ) -> List[Datasource]: + # TODO(bogdan): add unit test Review Comment: Don't leavel TODOs for other people! :) ```suggestion # TODO(hughhhh): add unit test ``` Or remove it altogether. ########## superset/dao/datasource/dao.py: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, List, Optional, Set, Union + +from flask_babel import _ +from sqlalchemy import or_ +from sqlalchemy.orm import Session, subqueryload +from sqlalchemy.orm.exc import NoResultFound + +from superset.connectors.sqla.models import SqlaTable +from superset.dao.base import BaseDAO +from superset.datasets.commands.exceptions import DatasetNotFoundError +from superset.datasets.models import Dataset +from superset.models.core import Database +from superset.models.sql_lab import Query, SavedQuery +from superset.tables.models import Table +from superset.utils.core import DatasourceType + +Datasource = Union[Dataset, SqlaTable, Table, Query, SavedQuery, Any] + + +class DatasourceDAO(BaseDAO): + + sources: Dict[DatasourceType, Datasource] = { + DatasourceType.SQLATABLE: SqlaTable, + DatasourceType.QUERY: Query, + DatasourceType.SAVEDQUERY: SavedQuery, + DatasourceType.DATASET: Dataset, + DatasourceType.TABLE: Table, + } + + @classmethod + def get_datasource( + cls, datasource_type: DatasourceType, datasource_id: int, session: Session + ) -> Datasource: + if datasource_type not in cls.sources: + raise DatasetNotFoundError() + + datasource = ( + session.query(cls.sources[datasource_type]) + .filter_by(id=datasource_id) + .one_or_none() + ) + + if not datasource: + raise DatasetNotFoundError() + + return datasource + + @classmethod + def get_all_datasources(cls, session: Session) -> List[Datasource]: + datasources: List[Datasource] = [] + for source_class in DatasourceDAO.sources.values(): + qry = session.query(source_class) + if isinstance(source_class, SqlaTable): + qry = source_class.default_query(qry) + datasources.extend(qry.all()) + return datasources + + @classmethod + def get_datasource_by_name( # pylint: disable=too-many-arguments + cls, + session: Session, + datasource_type: DatasourceType, + datasource_name: str, + schema: str, + database_name: str, + ) -> Optional[Datasource]: + datasource_class = DatasourceDAO.sources[datasource_type] + if isinstance(datasource_class, SqlaTable): + return datasource_class.get_datasource_by_name( + session, datasource_name, schema, database_name + ) + return None + + @classmethod + def query_datasources_by_permissions( # pylint: disable=invalid-name + cls, + session: Session, + database: Database, + permissions: Set[str], + schema_perms: Set[str], + ) -> List[Datasource]: + # TODO(bogdan): add unit test + datasource_class = DatasourceDAO.sources[DatasourceType[database.type]] + if isinstance(datasource_class, SqlaTable): + return ( + session.query(datasource_class) + .filter_by(database_id=database.id) + .filter( + or_( + datasource_class.perm.in_(permissions), + datasource_class.schema_perm.in_(schema_perms), + ) + ) + .all() + ) + return [] + + @classmethod + def get_eager_datasource( + cls, session: Session, datasource_type: str, datasource_id: int + ) -> Optional[Datasource]: + """Returns datasource with columns and metrics.""" + datasource_class = DatasourceDAO.sources[DatasourceType[datasource_type]] + if isinstance(datasource_class, SqlaTable): Review Comment: Same here, if you invert the if the code is a bit easier to read: ```python if not isinstance(datasource_class, SqlaTable): return None return (...) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
