kgabryje commented on code in PR #20010:
URL: https://github.com/apache/superset/pull/20010#discussion_r872302976
##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -340,11 +341,24 @@ export interface ControlPanelSectionConfig {
controlSetRows: ControlSetRow[];
}
+export interface SharedFormData {
+ metrics: AdhocMetric[];
+ columns: (AdhocColumn | PhysicalColumn)[];
+}
+
+export interface iStandardizedFormData {
Review Comment:
We don't use "i" prefix for interface anywhere else in the codebase. Maybe
we should rename it and stick to PascalCase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
