diegomedina248 opened a new pull request, #20058: URL: https://github.com/apache/superset/pull/20058
### SUMMARY [The copy command](https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand), though largely still supported, is deprecated. In Safari, latest versions, the copy to clipboard of a permalink no longer works because of it. This PR adds support for the Clipboard API, with all the nuances and small differences between the different browser engines. Be sure to read the comments & associated discussions linked for more information. [The new API is not yet fully supported by all browsers](https://caniuse.com/?search=clipboard%20api), so the current copy code was left as a fallback. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://user-images.githubusercontent.com/17252075/168292759-62bde4f0-c7bd-4491-a1a1-2e0706a3c9c9.mov After: https://user-images.githubusercontent.com/17252075/168292801-ce6471e6-4f9a-4bb3-8498-459dd38605c9.mov ### TESTING INSTRUCTIONS Go to any chart/dashboard and ensure the copy to permalink works across browsers. ### ADDITIONAL INFORMATION Fixes #19994 - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
