zhaoyongjie commented on PR #19918: URL: https://github.com/apache/superset/pull/19918#issuecomment-1127340164
> And the trickier one: When you transpose the chart between row and column orientation, the other controls may now confuse people. We refer to some of the controls as "x axis" and "y axis" which is no longer the case. > I think we need one of two possible solutions here: > • Update the terminology, like "Metric axis" and "Dimension axis" to be more specific > • Updating the labeling of the controls so that the X and Y labels update on the fly depending on chart orientation, and the controls remain "truthful" I totally agree, the label name of `x-axis` looks a bit misleading after it is rotated. The issue may not come from this PR, but from the current control panel design. - the purpose of the `query panel` design is to describe the query fragment. - the purpose of the `customize panel` design is to describe the properties of visualization. The Bar chart transposition is a circumstance that a mixed query generator and viz definition. 1) In a vertical bar chart: the x-axis should be dimensions, it is represented by `x-axis` control and `dimension` control, y-axis should be metric(s). 2) In a horizontal bar chart: the x-axis should be metric(s). The `y-axis` should be dimensions, it is represented by x-axis control and dimension control. Due to this confusing reason, lots of BI tools use `columns` and `rows` to represent `x-axis` and `y-axis` and provide many settings on each dimension/metric control.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
