zhaoyongjie commented on code in PR #20077:
URL: https://github.com/apache/superset/pull/20077#discussion_r873668064
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts:
##########
@@ -96,11 +96,11 @@ export default function buildQuery(formData: QueryFormData)
{
...baseQueryObject,
...{ is_timeseries },
}),
- flattenOperator(formData, baseQueryObject),
- // todo: move contribution and prophet before flatten
contributionOperator(formData, baseQueryObject),
+ flattenOperator(formData, baseQueryObject),
+ // todo: move prophet before flatten
prophetOperator(formData, baseQueryObject),
- ],
+ ].filter(op => op),
Review Comment:
Nice! The filter should apply in a separate PR and apply in all post
operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
