aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873835980


##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -221,7 +222,7 @@ class SliceAdder extends React.Component {
             innerRef={dragSourceRef}
             style={style}
             sliceName={cellData.slice_name}
-            lastModified={cellData.changed_on_humanized}
+            lastModified={moment.utc(cellData.changed_on).fromNow()}

Review Comment:
   changed_on_humanized has no translation. I will be glade to keep 
'changed_on_humanized' but what can I change so that the translation is done
   
   I move the change on this PR : https://github.com/apache/superset/pull/20082
   we can discuss about that on the new PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to