rusackas commented on code in PR #20086:
URL: https://github.com/apache/superset/pull/20086#discussion_r875094999
##########
superset-frontend/packages/superset-ui-core/src/style/index.tsx:
##########
@@ -160,6 +160,7 @@ const defaultTheme = {
},
transitionTiming: 0.3,
gridUnit: 4,
+ transparent: 'rgba(255, 255, 255, 0)',
Review Comment:
Heads up to @michael-s-molina @geido that we might want to consider this in
our Theme discussions. We might want to consider a means to add "opacity stops"
that we support for some use cases, and a means to use them as alpha channel
values on any given theme color, or perhaps as a styling mixin of some sort.
The reason being that this approach works great while we're in light/white
theming mode, but if we switched to dark mode or something, then we'd again see
weird grays as out gradient transitions toward transparent white.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
