villebro commented on code in PR #20107:
URL: https://github.com/apache/superset/pull/20107#discussion_r875746627
##########
superset-frontend/src/explore/controlUtils/getControlState.ts:
##########
@@ -90,7 +85,7 @@ export function applyMapStateToPropsToControl<T =
ControlType>(
const { mapStateToProps } = controlState;
let state = { ...controlState };
let { value } = state; // value is current user-input value
- if (mapStateToProps && controlPanelState) {
Review Comment:
we seem to be checking for truthiness of `controlPanelState` here and in a
few other places, despite the signature stating it will always be truthy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
