alec-heif opened a new issue, #20115:
URL: https://github.com/apache/superset/issues/20115

   See issue title
   
   #### How to reproduce the bug
   
   1. Add a Trino Database that has a specific catalog with connection string 
`trino://{username}:{password}@{hostname}:{port}/{catalog}`
   2. Attempt to add a Dataset with a schema and table name that exist in 
`catalog`. Let's say `my_schema` and `my_table`
   3. Look at the queries made to Trino.
   
   ### Expected results
   
   Superset should make a query like 
   
   ```
   SELECT "comment" 
   FROM "system"."metadata"."table_comments" 
   WHERE "schema_name" = 'default' 
   AND "table_name" = 'accounts'
   AND "catalog_name" = 'my_catalog'
   ```
   
   ### Actual results
   
   Superset makes a query like
   ```
   SELECT "comment" 
   FROM "system"."metadata"."table_comments" 
   WHERE "schema_name" = 'default' 
   AND "table_name" = 'accounts'
   ```
   
   which will erroneously include results for ALL catalogs that have a matching 
schema and table name.
   
   ### Environment
   
   - superset version: latest
   
   ### Checklist
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to