villebro opened a new pull request, #20123: URL: https://github.com/apache/superset/pull/20123
### SUMMARY #19917 migrated the `convert_dttm` functions in the Presto and Trino db engine specs to use the currently recommended literal timestamp type cast over the now deprecated `from_iso8601_*` functions. However, the new literal casts require the separator to be a blank space instead of the "T" separator: - https://trino.io/docs/current/functions/datetime.html - https://prestodb.io/docs/current/functions/datetime.html This PR updates the format to correspond with the supported format and updates the unit tests accordingly. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
