kgabryje commented on code in PR #20111:
URL: https://github.com/apache/superset/pull/20111#discussion_r876884452
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -104,9 +104,18 @@ const SliceHeader: FC<SliceHeaderProps> = ({
[crossFilterValue],
);
+ const handleClickTitle =
Review Comment:
It actually is the same reference! We don't create a new function here, only
either assign the one from props or undefined. So unless `onExploreChart`
changes on every render (and if it does, we should fix it there), the reference
will stay the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
