kgabryje commented on code in PR #20129:
URL: https://github.com/apache/superset/pull/20129#discussion_r876911866
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -699,12 +699,17 @@ function mapStateToProps(state) {
const chartKey = Object.keys(charts)[0];
const chart = charts[chartKey];
+ let dashboardId = Number(explore.form_data?.dashboardId);
+ if (Number.isNaN(dashboardId)) {
Review Comment:
`??` operator doesn't exclude NaNs. I also don't want to use `||` operator
in order not to exclude dashboards with id `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
