hughhhh commented on code in PR #20122:
URL: https://github.com/apache/superset/pull/20122#discussion_r877568664
##########
superset/cachekeys/api.py:
##########
@@ -83,13 +83,14 @@ def invalidate(self) -> Response:
return self.response_400(message=str(error))
datasource_uids = set(datasources.get("datasource_uids", []))
for ds in datasources.get("datasources", []):
- ds_obj = ConnectorRegistry.get_datasource_by_name(
+ ds_obj = DatasourceDAO.get_datasource_by_name(
session=db.session,
datasource_type=ds.get("datasource_type"),
Review Comment:
```suggestion
DatasourceType(datasource_type=ds.get("datasource_type"))
```
##########
superset/cachekeys/api.py:
##########
@@ -83,13 +83,14 @@ def invalidate(self) -> Response:
return self.response_400(message=str(error))
datasource_uids = set(datasources.get("datasource_uids", []))
for ds in datasources.get("datasources", []):
- ds_obj = ConnectorRegistry.get_datasource_by_name(
+ ds_obj = DatasourceDAO.get_datasource_by_name(
session=db.session,
datasource_type=ds.get("datasource_type"),
Review Comment:
```suggestion
DatasourceType(datasource_type=ds.get("datasource_type"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
