yousoph commented on PR #19965:
URL: https://github.com/apache/superset/pull/19965#issuecomment-1133149946

   Two things I noticed: 
   
   1. In the add chart flow, the dataset in the dropdown isn't styled the same 
way as if you had selected the dataset manually
   
![image](https://user-images.githubusercontent.com/10627051/169580887-8c6b1a32-3be2-40fc-ade5-0d461adeb95c.png)
   
   2. I think it would be smoother to bring the user directly to the create 
chart flow without the user seeing the dataset CRUD view in between, if we can 
do that. The dataset created confirmation toast could appear on the create 
chart page (instead of on the CRUD view) 
   
   cc @jess-dillard if you want to test on the ephemeral & for feedback on 
point 2  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to