john-bodley opened a new pull request, #20152: URL: https://github.com/apache/superset/pull/20152
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR provides a number of updates for the Trino engine including: 1. Making the `TrinoEngineSpec` derive from the `PrestoEngineSpec` rather than the `BaseEngineSpec`. I'm not really sure as to why the later was used as it violates the DRY principle and also means that many of the Presto customizations—which Trino is forked from—were previously not defined. 2. Renames `trinonative` to `trino`—which requires a PyHive bump—thanks to @betodealmeida's work https://github.com/dropbox/PyHive/pull/428. I thought there was merit going forward using `trino` rather than `trinonative` everywhere. 3. Added a `TrinoTemplateProcessor` so macros like `{{ trino.latest_partition(...) }}` etc. can be used. Note made sure the processor also supported the `presto` key for backwards compatibility given that it is likely people will be migrating from Presto and the `presto` key is likely embedded in saved queries, virtual datasets, etc. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
