villebro commented on code in PR #19554:
URL: https://github.com/apache/superset/pull/19554#discussion_r882409304
##########
superset-frontend/packages/superset-ui-core/src/query/types/PostProcessing.ts:
##########
@@ -121,19 +121,20 @@ interface _PostProcessingPivot {
}
export type PostProcessingPivot = _PostProcessingPivot | DefaultPostProcessing;
-interface _PostProcessingProphet {
- operation: 'prophet';
+interface _PostProcessingForecast {
+ operation: 'forecast';
options: {
time_grain: TimeGranularity;
periods: number;
confidence_interval: number;
yearly_seasonality?: boolean | number;
weekly_seasonality?: boolean | number;
daily_seasonality?: boolean | number;
+ model_name: string;
};
}
Review Comment:
As renaming the post processing op is a breaking change, I think we should
migrate existing `query_context` column data in the `slices` table as follows:
- update operation from `prophet` to `forecast` where there exists
`"operation": "prophet"`
- while we're at it, maybe also explicitly set `model_name` to
`prophet.Prophet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
