eschutho commented on code in PR #19981:
URL: https://github.com/apache/superset/pull/19981#discussion_r872890675
##########
superset/explore/form_data/commands/update.py:
##########
@@ -64,7 +65,7 @@ def run(self) -> Optional[str]:
# Generate a new key if tab_id changes or equals 0
tab_id = self._cmd_params.tab_id
contextual_key = cache_key(
- session.get("_id"), tab_id, dataset_id, chart_id
+ session.get("_id"), tab_id, datasource_id, chart_id,
datasource_type
Review Comment:
So currently on update, if the first key can't be found, it will create a
new key and return it. That seems ok to me.. do you think that could work for
this temporary cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
