zhaoyongjie opened a new pull request, #20242:
URL: https://github.com/apache/superset/pull/20242

   ### SUMMARY
   The legacy line chart(NVD3) with the time shift has a feature that the 
derived metrics were displayed `dashed line` rather than a `solid line`. For 
example, a `Line Chart` has a metric be called `sum(sales)`, and select time 
shift `1 month ago` in `Advanced Analytics`, the line of `sum(sales)` was 
displayed `solid line` and derived metric `sum(sales)__1 month ago` was 
displayed `dashed line`.
   
   This PR introduces this feature on the new chart.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   ### After
   
![image](https://user-images.githubusercontent.com/2016594/171612311-45d7e875-95e9-4113-b558-a8e4ccbc17fb.png)
   
   ### Before
   
![image](https://user-images.githubusercontent.com/2016594/171612391-5f18394a-0153-4b99-b048-788e6db0f5cc.png)
   
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to