villebro commented on code in PR #20088: URL: https://github.com/apache/superset/pull/20088#discussion_r888850005
########## superset/db_engine_specs/postgres.py: ########## @@ -21,6 +21,7 @@ from typing import Any, Dict, List, Optional, Pattern, Tuple, TYPE_CHECKING from flask_babel import gettext as __ +from psycopg2.extensions import binary_types, string_types Review Comment: I think this import should be moved into `get_datatype`, as `psycopg2` isn't a required dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
