kasiazjc commented on PR #20248: URL: https://github.com/apache/superset/pull/20248#issuecomment-1146017370
Looks good to me! One thing about the charts: we chose time-series (line, bar) as they will be becoming the default after the generic x-axis will be introduced for everyone. They have also similar statistics in terms of how much they are used (time series vs not). Question: do we want to leave time-series charts, go back to simple line/bar OR add a logic which for example shows time-series ones if you have feature flag enabled and for others it shows basic line/bar? All of those are in Tier 1, so I think we need a product decision here. Thoughts @rusackas @alaud? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
