reesercollins opened a new pull request, #20278: URL: https://github.com/apache/superset/pull/20278
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY When editing a dataset in superset, if you click away while editing, you lose all your progress. This change prevents the modal from closing when clicking outside its boundary when you're in edit mode. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/10563996/172172403-98b6f3b5-84a6-4b7e-b7b8-a52f085fd7fb.mp4 ### TESTING INSTRUCTIONS 1. Open the edit dataset modal 2. Click outside the modal boundary. It should close 3. Re-open the edit dataset modal 4. Click the lock icon to enable editing mode 5. Click outside the modal boundary. It should not close. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Required feature flags: `DISABLE_DATASET_SOURCE_EDIT: False` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
