srinify commented on code in PR #20264: URL: https://github.com/apache/superset/pull/20264#discussion_r892436765
########## docs/docs/databases/druid.mdx: ########## @@ -18,6 +18,7 @@ The connection string looks like: ``` druid://<User>:<password>@<Host>:<Port-default-9088>/druid/v2/sql ``` +Where User and password are the credentials of your **Druid Database** , Host is your machine's IP address and Port is the port at which **Druid Database** is running. Review Comment: Some quick feedback! It would be a bit more visually cleaner to turn this into a list: "Here's a breakdown of the key parts of this connection string: - User: username portion of the credentials needed to connect to your database - Password: password portion of the credentials needed to connect to your database - Host: IP address (or URL) of the host machine that's running your database - Port: specific port that's exposed on your host machine where your database is running" This way, we can also add this to the other database pages as well and it's a bit more generalized! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
