[GitHub] [superset] lyndsiWilliams opened a new pull request, #20317: chore(explore): Visual updates to explore datasource panel

[GitBox]

lyndsiWilliams opened a new pull request, #20317:
URL: https://github.com/apache/superset/pull/20317

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Made the following visual updates to the explore datasource panel:
   - Changed "Dataset" to "Chart Source"
     - Increased font size to 14px
   - Removed "More dataset related options" tooltip
   - Moved inner collapse icon to the right by 8px
   - Removed outer dataset icon when panel is collapsed
   - Changed icon to ConsoleSqlOutlined when chart source is a Query
   - User sees beginning of SQL query when chart source is a Query
   
   ### SCREENSHOTS
   <!--- Skip this if not applicable -->
   #### When chart source is a Query:
   <img width="353" alt="panelUpdateAfter" 
src="https://user-images.githubusercontent.com/55605634/172693294-4eba9916-a054-4e3f-a67a-c63d9cfc681f.png";>
   
   #### When chart source is not a Query:
   <img width="353" alt="panelUpdateAfter2" 
src="https://user-images.githubusercontent.com/55605634/172693307-3100cd44-c3e2-41a3-ac90-1bfaec9e52eb.png";>
   
   #### Collapsed panel (no longer has an icon):
   <img width="353" alt="panelUpdateAfter3" 
src="https://user-images.githubusercontent.com/55605634/172693318-4ad4bdeb-6f04-4410-9e8f-ca3a6335a274.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   - Go to explore by opening any chart
   - Observe the visual updates
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org