zhaoyongjie commented on code in PR #20318:
URL: https://github.com/apache/superset/pull/20318#discussion_r893305394


##########
RELEASING/README.md:
##########
@@ -422,13 +422,47 @@ with the changes on `CHANGELOG.md` and `UPDATING.md`.
 
 ### Publishing a Convenience Release to PyPI
 
-Using the final release tarball, unpack it and run `./pypi_push.sh`.
-This script will build the JavaScript bundle and echo the twine command
-allowing you to publish to PyPI. You may need to ask a fellow committer to 
grant
+Extract the release to the `/tmp` folder to build the PiPY release. Files in 
the `/tmp` folder will be automatically deleted by the OS.
+
+```bash
+cd /tmp
+tar xfvz ~/svn/superset/${SUPERSET_VERSION}/${SUPERSET_RELEASE_TARBALL}
+```
+
+Create a virtual environment and install the dependencies
+
+```bash
+cd ${SUPERSET_RELEASE_RC}
+virtualenv venv

Review Comment:
   ```suggestion
   python3 -m venv venv
   ```



##########
RELEASING/README.md:
##########
@@ -422,13 +422,47 @@ with the changes on `CHANGELOG.md` and `UPDATING.md`.
 
 ### Publishing a Convenience Release to PyPI
 
-Using the final release tarball, unpack it and run `./pypi_push.sh`.
-This script will build the JavaScript bundle and echo the twine command
-allowing you to publish to PyPI. You may need to ask a fellow committer to 
grant
+Extract the release to the `/tmp` folder to build the PiPY release. Files in 
the `/tmp` folder will be automatically deleted by the OS.
+
+```bash
+cd /tmp
+tar xfvz ~/svn/superset/${SUPERSET_VERSION}/${SUPERSET_RELEASE_TARBALL}

Review Comment:
   Preventing files collisions, create a new directory
   ```suggestion
   mkdir -p /tmp/superset && cd /tmp/superset
   tar xfvz ~/svn/superset/${SUPERSET_VERSION}/${SUPERSET_RELEASE_TARBALL}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to