codyml opened a new pull request, #20337: URL: https://github.com/apache/superset/pull/20337
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Reorders/renames tabs for clarity, so Charts is first/default Components is instead named Layout Elements. Adds tests for `BuilderComponentPane` and relocates component and test files to meet file hierarchy recommendations. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before  #### After  ### TESTING INSTRUCTIONS Unit test: ```shell cd superset-frontend npm run test -- src/dashboard/components/BuilderComponentPane/BuilderComponentPane.test.tsx ``` **Note: despite passing, running test shows lots of console warning/errors – any idea why?** Manual check: check that clicking "Edit Dashboard" opens panel with Chart tab first and selected by default and Layout Elements tab second. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
