ktmud opened a new issue, #20381:
URL: https://github.com/apache/superset/issues/20381

   When users don't have edit access to a chart or view access to a dataset, 
but have access to a dashboard, they will still be able to view the chart in 
the dashboard, but cannot view the chart in explore. Previously, they can still 
view the chart in Explore regardless if they have access to the chart to 
dataset.
   
   This change breaks users' workflow in a couple of ways:
   
   1. If they loose access to a dataset, they will not be able to go to the 
original chart (which they actually have access to) to point it to a new dataset
   2. Users won't be able to explore the data in depth, even when they can 
actually view the data from dashboards.
   
   #### How to reproduce the bug
   
   Using the examples data:
   
   1. Login as admin, assign "gamma user" to a dashboard
   2. Login as "gamma user", go to the dashboard (do this in an Incognito 
window to avoid having to logout and login)
   3. Try to "Edit chart" from the dashboard
      <img width="757" alt="image" 
src="https://user-images.githubusercontent.com/335541/173638927-603ae0e1-f565-41d1-8f09-711b38c0891e.png";>
   
   ### Expected results
   
   Users should be able to open the "Edit chart" link regardless if they have 
access to a chart/dataset. The access should be controlled on the Explore page.
   
   If users cannot see the content of the chart, then the Edit chart link 
should be removed or disabled.
   
   ### Actual results
   
   Edit chart is visible but clicking on it shows an error:
   
   
![error-explore](https://user-images.githubusercontent.com/335541/173639292-3cfd9a3f-f5b7-40cc-bf2b-ddf1acb44e09.gif)
   
   ### Environment
    
   Latest maste (sha: 86f146e217ddb7c2ebd499acddaa5e8c3b3ab560)
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to