[GitHub] [superset] aehanno commented on pull request #20080: fix : translating variables

Wed, 15 Jun 2022 06:50:02 -0700 


aehanno commented on PR #20080:
URL: https://github.com/apache/superset/pull/20080#issuecomment-1156500202

   > @aehanno can you show a before and after of these changes? I'd like to 
understand how these translations are being picked up
   
   Hey @villebro, yes of course, I can show you an exemple.
   It's in dashboard edition in charts tab.
   
   For this one, I added modification in SliceAdder.jsx file, 
   
   There is before my correction `label: t('Sort by %s', label),`
   
![Before](https://user-images.githubusercontent.com/104373599/173842421-724f011a-eeba-4936-8c07-af601c2917e1.png)
   
   And this one is after my correction `label: t('Sort by %s', t(label)),`
   
![After](https://user-images.githubusercontent.com/104373599/173842508-4b870fed-1cc4-4d0a-94c0-021df76fad97.png)
   
   We can see the second part is well translate in the second image
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to