rusackas commented on code in PR #20295:
URL: https://github.com/apache/superset/pull/20295#discussion_r902676141
##########
superset-frontend/src/views/components/MenuRight.tsx:
##########
@@ -35,6 +35,7 @@ import Icons from 'src/components/Icons';
import findPermission, { isUserAdmin } from
'src/dashboard/util/findPermission';
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
import { RootState } from 'src/dashboard/types';
+import { Tag } from 'antd';
Review Comment:
Rather than importing the `Tag` component directly from antd, we should
probably `import Label from 'src/components/Label';` since that'll be the
highly reused and restyled/supported component in most (hopefully all) Superset
instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
