SusurHe opened a new pull request, #20462:
URL: https://github.com/apache/superset/pull/20462

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Move spark engine spec in `hive.py` to a new file: `spark.py` and support 
Spark 3.x DateFormat; 
   
   1. As tools like Kyuubi are gradually maturing, spark SQL has greater 
advantages than hive, and pyhive can not meet some of the features of spark 
SQL. I think it would be better to take spark SQL Engine spec alone; It is also 
convenient to provide better Kyuubi or spark server support in the future;
   2. Spark3.0 remove date format string[apache/superset/pull/18690], 
DatabricksEngineSpec have fixed it: 
<https://issues.apache.org/jira/browse/SPARK-31892> but Spark SQL engine is 
not, so i simply fix it;
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
![image](https://user-images.githubusercontent.com/51081799/174930155-050bbb37-8c1d-48cb-86f6-98e72d1036d3.png)
   
![image](https://user-images.githubusercontent.com/51081799/174935191-bcc9b55e-0678-4295-ab26-085beb9c3f98.png)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   connect and query see screenshots;
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to