eschutho commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r904092325
##########
superset/models/sql_lab.py:
##########
@@ -179,6 +232,53 @@ def raise_for_access(self) -> None:
security_manager.raise_for_access(query=self)
+ @property
+ def db_engine_spec(self) -> Type["BaseEngineSpec"]:
+ return self.database.db_engine_spec
+
+ @property
+ def owners_data(self) -> List[Dict[str, Any]]:
+ return []
+
+ @property
+ def metrics(self) -> List[Any]:
Review Comment:
are we removing or keeping this? I feel we should be cautious about not
adding properties to the model that don't naturally work. Like we shouldn't
shoe-horn this model into being something that it's not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
