[GitHub] [superset] stephenLYZ opened a new pull request, #20488: fix(big-number): big number gets cut off on a Dashboard

[GitBox]

stephenLYZ opened a new pull request, #20488:
URL: https://github.com/apache/superset/pull/20488

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   In the big number chart, we will currently use `computeMaxFontSize` to 
measure the font size, where the incoming width is the actual width of the 
chart. After testing, it is found that the calculated font size has a certain 
error, resulting in truncation in the dashboard. So here we decrease 4px of the 
width to display fonts of different text lengths well.
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   ### before
   <img width="243" alt="image" 
src="https://user-images.githubusercontent.com/11830681/175508434-d0246b42-2fec-45c1-a557-5a657ab6629e.png";>
   
   ### after
   <img width="313" alt="image" 
src="https://user-images.githubusercontent.com/11830681/175508325-70923b69-df1f-4eb6-adea-9c92184dfe0a.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org