eschutho commented on code in PR #20491:
URL: https://github.com/apache/superset/pull/20491#discussion_r907699544
##########
superset/sqllab/command.py:
##########
@@ -110,7 +115,21 @@ def run( # pylint:
disable=too-many-statements,useless-suppression
"status": status,
"payload":
self._execution_context_convertor.serialize_payload(),
}
- except (SqlLabException, SupersetErrorsException) as ex:
+ except SupersetErrorsException as ex:
+ if all(ex.error_type == SupersetErrorType.SYNTAX_ERROR for ex in
ex.errors):
+ raise SupersetSyntaxErrorException(ex.errors) from ex
+ raise ex
+ except SupersetException as ex:
Review Comment:
I noticed that we were catching SqlLabException before. This one is a parent
class, correct, so it should still work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
