mdeshmu commented on issue #17011: URL: https://github.com/apache/superset/issues/17011#issuecomment-1170417083
What i meant is, To capture QueryExecutionId, we would need a separate thread utilizing the same cursor that is used for running sql statements from SQL Lab but current [location of invocation](https://github.com/apache/superset/blob/master/superset/sql_lab.py#L467) of get_cancel_query_id wouldn't give us QueryExecutionId because its invoked before [execution of SQL statements](https://github.com/apache/superset/blob/master/superset/sql_lab.py#L491). Even if we move [this](https://github.com/apache/superset/blob/master/superset/sql_lab.py#L467) after [execution of SQL statements](https://github.com/apache/superset/blob/master/superset/sql_lab.py#L491) then also its of no use as cursor would be blocked until the query execution is finished and get_cancel_query_id would be called after query execution has finished. Please correct me if I am wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
