codyml opened a new pull request, #20561: URL: https://github.com/apache/superset/pull/20561
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> While working on #20560 I ended up doing some cleaning up of typing for the Dashboard view: - `./reducers/types.ts` looked like it contained mostly unused types and almost-duplicates of types in `./types.ts`, so I moved the few types that were actually in use to `./types.ts` and deleted `./reducers/types.ts`. - Some of the types in `./types.ts` were also unused or didn't accurately describe what they were typing, so I rewrote a lot of that file. - I converted `./actions/hydrate.js` to TypeScript, mostly in an effort to try to get some additional assurance that removing `charts[i].formData` wouldn't break anything. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> No functionality should be impacted by this PR, so try out as much Dashboard functionality as possible, especially editing dashboards, and make sure nothing behaves differently than before. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
