zys2017 commented on code in PR #20559:
URL: https://github.com/apache/superset/pull/20559#discussion_r910673344
##########
superset/models/core.py:
##########
@@ -760,11 +760,11 @@ def get_perm(self) -> str:
def has_table(self, table: Table) -> bool:
engine = self.get_sqla_engine()
- return engine.has_table(table.table_name, table.schema or None)
+ return engine.has_table(table.table_name, table.schema or None) or
table.table_name in engine.table_names()
Review Comment:
Table_names is the function of orm and seems effective to other db
source，not only kylin. It can avoid that the engine does not implement relevant
functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
